Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use license key #423

Closed
wants to merge 1 commit into from
Closed

Use license key #423

wants to merge 1 commit into from

Conversation

Calneideck
Copy link
Contributor

Update to pass the license key from the component to the TinyMCE instance to avoid console warnings when using the self hosted scripts.

@Calneideck Calneideck requested a review from a team as a code owner July 24, 2024 07:01
@Calneideck Calneideck requested review from spocke, TheSpyder and ltrouton and removed request for a team July 24, 2024 07:01
@EkimChau
Copy link
Contributor

Hello Calneideck

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this is a simple process that can be cpmpleted through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement. Once we receive the CLA, Tiny will merge the PR, attribute the change log improvement to Calneideck, distribute the release.

@danoaky-tiny danoaky-tiny mentioned this pull request Jul 25, 2024
Merged
@Calneideck
Copy link
Contributor Author

I have emailed [email protected] and had no response, but regardless, you have my permission to use this line of code :)

@EkimChau
Copy link
Contributor

Hi Calneideck,
Thanks for the response and support. I've kept an eye out for your request, it just hasn't come through, the email you used is correct. Could you try and resend when you get a chance? We'll keep an eye out for your handle.

@Calneideck
Copy link
Contributor Author

Still nothing...

@Calneideck
Copy link
Contributor Author

Can this be merged in please? It's blocking our update to TinyMCE 7.

@ltrouton
Copy link
Contributor

Closing this PR as it has been merged into #447. Thanks @Calneideck

@ltrouton ltrouton closed this Oct 22, 2024
@Calneideck Calneideck deleted the use-license-key branch October 22, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoaky-tiny danoaky-tiny danoaky-tiny approved these changes

@kemister85 kemister85 kemister85 approved these changes

@MitchC1999 MitchC1999 MitchC1999 approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

@ArvinJ-H ArvinJ-H Awaiting requested review from ArvinJ-H

@hamza0867 hamza0867 Awaiting requested review from hamza0867

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny

@FarzadHayat FarzadHayat Awaiting requested review from FarzadHayat

Assignees
No one assigned
Labels
Community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Calneideck @EkimChau @ltrouton @MitchC1999 @kemister85 @danoaky-tiny